Skip to content

refactor: cargo manifests (incl. dependency cleanup) #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2025

Conversation

magistau
Copy link
Contributor

@magistau magistau commented Aug 7, 2025

  • use workspace inheritance for dependencies and metadata
  • use clippy::cargo
  • update some dependencies to deduplicate some others; can be improved further by updating leptos and downgrading dashmap, see .clippy.toml

@@ -0,0 +1,35 @@
allowed-duplicate-crates = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you delete this file and just allow multiple crate versions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to have to mess with this file if I tweak dependencies.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, the less configuration I need to maintain, the better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lint gives a good way to see which dependencies are duplicated, which is one of the three things this PR does. I've split off the commit to make it clearer.

@kaikalii kaikalii merged commit c10880c into uiua-lang:main Aug 14, 2025
5 checks passed
@magistau magistau deleted the workspace branch August 14, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants